bader added a comment.

@aaron.ballman, it looks like unittests should be updated as well. Please, take 
a look at failures in pre-merge checks.



================
Comment at: clang/include/clang/Basic/LangOptions.def:252
 LANGOPT(SYCLIsDevice      , 1, 0, "Generate code for SYCL device")
+LANGOPT(SYCLIsHost        , 1, 0, "SYCL host compilation")
 ENUM_LANGOPT(SYCLVersion  , SYCLMajorVersion, 1, SYCL_None, "Version of the 
SYCL standard used")
----------------
I'm okay with that change, but IIRC, @ABataev suggested to have both -fsycl and 
-fsycl-is-device options to align with OpenMP mode (full discussion is here - 
https://reviews.llvm.org/D72857#inline-674377).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97717/new/

https://reviews.llvm.org/D97717

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to