Author: Nathan James Date: 2021-03-03T16:01:13Z New Revision: 19aefd2d5dc3a8d3b8e81219973828170b7fcd2c
URL: https://github.com/llvm/llvm-project/commit/19aefd2d5dc3a8d3b8e81219973828170b7fcd2c DIFF: https://github.com/llvm/llvm-project/commit/19aefd2d5dc3a8d3b8e81219973828170b7fcd2c.diff LOG: [clang-tidy] Deprecate readability-deleted-default check ... For removal in next release cycle. The clang warning that does the same thing is enabled by default and typically emits better diagnostics making this check surplus to requirements. Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D97491 Added: Modified: clang-tools-extra/docs/ReleaseNotes.rst clang-tools-extra/docs/clang-tidy/checks/readability-deleted-default.rst Removed: ################################################################################ diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index 77a01b2001aa..91207090902d 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -112,6 +112,16 @@ Changes in existing checks function or assignment to ``nullptr``. Added support for pointers to ``std::unique_ptr``. +Deprecated checks +^^^^^^^^^^^^^^^^^ + +- The :doc:`readability-deleted-default + <clang-tidy/checks/readability-deleted-default>` check has been deprecated. + + The clang warning `Wdefaulted-function-deleted + <https://clang.llvm.org/docs/DiagnosticsReference.html#wdefaulted-function-deleted>`_ + will diagnose the same issues and is enabled by default. + Improvements to include-fixer ----------------------------- diff --git a/clang-tools-extra/docs/clang-tidy/checks/readability-deleted-default.rst b/clang-tools-extra/docs/clang-tidy/checks/readability-deleted-default.rst index 00134eb05484..5f2083e00061 100644 --- a/clang-tools-extra/docs/clang-tidy/checks/readability-deleted-default.rst +++ b/clang-tools-extra/docs/clang-tidy/checks/readability-deleted-default.rst @@ -3,20 +3,6 @@ readability-deleted-default =========================== -Checks that constructors and assignment operators marked as ``= default`` are -not actually deleted by the compiler. - -.. code-block:: c++ - - class Example { - public: - // This constructor is deleted because I is missing a default value. - Example() = default; - // This is fine. - Example(const Example& Other) = default; - // This operator is deleted because I cannot be assigned (it is const). - Example& operator=(const Example& Other) = default; - - private: - const int I; - }; +This check has been deprecated prefer to make use of the `Wdefaulted-function-deleted +<https://clang.llvm.org/docs/DiagnosticsReference.html#wdefaulted-function-deleted>`_ +flag. _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits