paulwalker-arm added inline comments.

================
Comment at: llvm/docs/LangRef.rst:1998
+    function. A value of 0 means unbounded. If the optional max value is 
omitted
+    then max is set to the value of min.
 
----------------
sdesmalen wrote:
> Do you need to say anything about a default if the attribute is not set, e.g. 
> if `vscale_range` is not set, no assumptions are made about the range of 
> vscale and the compiler falls back on the architectural maximum (if 
> available).
When the attribute is omitted there is no implicit knowledge and thus I'd stop 
at "... no assumptions are made about the range of vscale."

I would have though such a condition is implicit across most attributes (i.e. 
if omitted then no extra information is available) but I guess it cannot hurt 
to be explicit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98030/new/

https://reviews.llvm.org/D98030

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to