sbc100 marked 2 inline comments as done. sbc100 added inline comments.
================ Comment at: libcxx/test/std/language.support/cstdalign/cstdalign.pass.cpp:14-28 +#ifdef alignas +#error alignas should not be a macro in C++ +#endif + +#ifdef alignof +#error alignof should not be a macro in C++ +#endif ---------------- ldionne wrote: > This can be moved outside of `main()`. I was copying from `libcxx/test/std/language.support/cstdint/cstdint.syn/cstdint.pass.cpp` which does these checks inside of main. Will move them. ================ Comment at: libcxx/test/std/language.support/cstdalign/cstdalign.pass.cpp:27 +#ifndef __alignof_is_defined +#error __alignof_is_defined not defined +#endif ---------------- ldionne wrote: > I'm not seeing `__alignof_is_defined` anywhere in the spec? Removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
