courbet added inline comments. ================ Comment at: include/clang/AST/ASTContext.h:824 @@ -823,1 +823,3 @@ unsigned overridden_methods_size(const CXXMethodDecl *Method) const; + const ArrayRef<const CXXMethodDecl *> overridden_methods( + const CXXMethodDecl *Method) const; ---------------- aaron.ballman wrote: > courbet wrote: > > aaron.ballman wrote: > > > This is too tight of a coupling to the underlying datatype. It should > > > return `iterator_range<overridden_cxx_method_iterator>` > > This is the exact opposite of the change that Samuel just requested > > (implementing the iterators in term of the ArrayRef getter). I don't have a > > strong opinion on this, but could you two agree on the desired API ? > I hadn't noticed that we disagreed, sorry for the conflicting advice. > However, I strongly think that we should use an abstraction, and that > ArrayRef is too concrete. FWIW, we use iterator_range in almost every other > case in the code base when we refactored to rangify code. Samuel, are you OK with this (reverting the last change and using iterator_range instead of ArrayRef) ?
http://reviews.llvm.org/D19324 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
