njames93 added inline comments.
================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:575
return CB(InpAST.takeError());
- auto Selections = tweakSelection(Sel, *InpAST);
+ // FIXME: Should we use the dirty fs here?
+ auto FS = TFS.view(llvm::None);
----------------
Regarding this, Is it wise to set the contract so that Tweak::prepare isn't
allowed to do IO so we should just pass a nullptr here, inline with how
prepareRename works.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93978/new/
https://reviews.llvm.org/D93978
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
