awarzynski added a comment.
Thank you for updating this @arnamoy10 !
================
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:26
#include "llvm/Support/raw_ostream.h"
+
+#include "llvm/Support/FileSystem.h"
----------------
Not needed
================
Comment at: flang/lib/Frontend/CompilerInvocation.cpp:292
+ std::string driverPath = llvm::sys::fs::getMainExecutable(nullptr, nullptr);
+ driverPath = driverPath.substr(0, driverPath.find_last_of("/\\"));
+ return driverPath.append("/../tools/flang/include/flang/");
----------------
This will not work on Windows, will it? I couldn't find any API to deal with
this in a OS-agnostic way. Perhaps just remove 9 characters at the end? Or use
`#ifndef _WIN32`?
================
Comment at: flang/test/Driver/Inputs/ieee_arithmetic.mod:1
+! DUMMY module
+module ieee_arithmetic
----------------
I think that currently the contents of this file are not relevant. So I would
limit it to some helpful comment, e.g.:
```
Added for testing purposes. The contents of this file are currently not
relevant.
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97080/new/
https://reviews.llvm.org/D97080
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
