davide added a comment. In D98458#2620731 <https://reviews.llvm.org/D98458#2620731>, @MaskRay wrote:
>> Mach-O doesn't support dso_local and this change broke XNU because of the >> use of dso_local. > > Can you elaborate on the unsupportness? For example, the backend can ignore > dso_local if it does not want to support it. > > The main purpose is to reduce target differences: currently both COFF and ELF > can use dso_local. If Mach-O doesn't like dso_local, there is an additional > difference. The model for `dso_local` is different on Mach-O. While it's a laudable goal to unify the three formats, we might want to consider to not push these changes willy-nilly. We should consider investigating what's broken but the reality is that this breaks xnu so we need to revert this for the time being. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98458/new/ https://reviews.llvm.org/D98458 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
