jrtc27 added inline comments.
================ Comment at: llvm/test/CodeGen/RISCV/patchable-function-entry.ll:1-3 +;; Test the function attribute "patchable-function-entry". +; RUN: llc -mtriple=riscv32 < %s | FileCheck %s --check-prefixes=CHECK,32 +; RUN: llc -mtriple=riscv64 < %s | FileCheck %s --check-prefixes=CHECK,64 ---------------- luismarques wrote: > jrtc27 wrote: > > Please match the style of the other tests: > > - update_llc_test_checks.py > > - RV32I/RV32IC/RV64I/RV64IC > > Please match the style of the other tests: > > - update_llc_test_checks.py > > I was going to comment on that but I was unsure it applied here, given that > this test was running more than just `llc`. The other RISC-V CodeGen tests we > have with objdump don't use the update script IIRC. (And these manual tests > were neatly written and much more condensed that the sprawling output of the > auto updated checks). But I agree that in general using the script is the way > to go for the RISC-V tests. Yeah, though as you'll see in my comment below I don't think using llvm-objdump adds any value, at which point UTC works just fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98610/new/ https://reviews.llvm.org/D98610 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
