beanz added a comment. I'm super sorry to be popping in so late on this. Is this really the direction we should take?
If we know SystemZ + LLD + LTO is a bad configuration, "fixing" the configuration and logging a message seems like the wrong move when the only way to get into that state is to specifically request options. The CMake cache files are morally equivalent to a user specifying the config they want, and this patch accepts an invalid configuration and mutates it. Our CMake output is so noisy, that a user who actually wants LTO on SystemZ might never notice that they aren't getting it. It seems to me, your intent is to make the stage3 build work for SystemZ, and that seems like something we should accomplish entirely inside the stage3 CMake caches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89942/new/ https://reviews.llvm.org/D89942 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
