yaxunl marked an inline comment as done. yaxunl added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:271 + } + if (LatestROCm < FileName) + LatestROCm = FileName.str(); ---------------- tra wrote: > This will rank `rocm-3.9` higher than `rocm-3.10`. I think you do need to > extract and compare the version. Good catch. Will fix it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98867/new/ https://reviews.llvm.org/D98867 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
