aaronpuchert added a comment.

In D99005#2640415 <https://reviews.llvm.org/D99005#2640415>, @mizvekov wrote:

> We should expect the test above to work, by binding value to the rvalue 
> reference in task's promise, right?

Precisely, we don't want to do any initialization at all. (There will be an 
initialization for the parameters in `BuildCallExpr`.)

Implicit move just means that we're converting the lvalue to an xvalue.

On second thought, since @Quuxplusone's proposal makes things so simple you can 
just do this right yourself: instead of the initialization just do the cast, as 
D68845 <https://reviews.llvm.org/D68845> does it. That's it.

Then let's see what we can get for C++20. If the proposal is accepted and gets 
DR status for `co_return` we might not need my change at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99005/new/

https://reviews.llvm.org/D99005

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to