svenvh accepted this revision. svenvh added a comment. LGTM; just one minor comment, which you can address as part of your commit.
================ Comment at: clang/test/CodeGenOpenCLCXX/addrspace-with-class.clcpp:2 +// RUN: %clang_cc1 %s -triple spir-unknown-unknown -emit-llvm -O0 -o - | FileCheck %s // RUN: %clang_cc1 %s -triple spir-unknown-unknown -cl-std=CLC++ -emit-llvm -O0 -o - | FileCheck %s --check-prefix=CHECK-DEFINITIONS ---------------- Nitpick: this `-cl-std` can be removed too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.org/D96771 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
