benlangmuir added a comment.
LGTM with one comment about the doxygen comments, but you should probably wait
to hear from @akyrtzi too.
================
Comment at: include/clang/Sema/CodeCompleteConsumer.h:916
@@ +915,3 @@
+ /// \name Code-completion filtering
+ //@{
+ /// \brief Check if the result should be filtered out.
----------------
Do we really need a group here for just one method? If we do need the group,
there should be a matching `@}`. And it's missing one of the slashes (should
be `/// @{`).
Repository:
rL LLVM
http://reviews.llvm.org/D17820
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
