Re: [PATCH] D19084: [scan-build] fix warnings emitted on Clang AST code base

[Richard Trieu via cfe-commits]

rtrieu added inline comments.

================
Comment at: lib/AST/ASTDiagnostic.cpp:1686
@@ -1685,3 +1685,3 @@
 
-    if (Same) {
+    if (Same && FromTD) {
       OS << "template " << FromTD->getNameAsString();
----------------
dblaikie wrote:
> Should this be a condition, or just an assertion?
This should be an assertion.  Same == true implies FromTD and ToTD are not null.


http://reviews.llvm.org/D19084



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits