mstorsjo added a comment.

In D94355#2657881 <https://reviews.llvm.org/D94355#2657881>, @mstorsjo wrote:

> It looks like this is breaking the Windows/ARM(64) target - it doesn't 
> produce the right relative relocations for symbol differences. It can be 
> reproduced with a testcase like this:
>
> [...]
>
> Those relocations would need to be IMAGE_REL_ARM64_REL32. It looks like the 
> arm/windows target has got the same issue as well.
>
> Would you be ok with reverting this change until I can sort that out, or can 
> we disable the pass for those targets until then?

It turned out to not be all that hard to fix actually, see D99572 
<https://reviews.llvm.org/D99572> for such a fix. If I can get that landed 
soon, I think we might not need to act on this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94355/new/

https://reviews.llvm.org/D94355

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to