wmi added inline comments.
================ Comment at: clang/lib/CodeGen/BackendUtil.cpp:1583 ModuleToDefinedGVSummaries[M->getModuleIdentifier()], - ModuleMap, CGOpts.CmdArgs)) { + nullptr, CGOpts.CmdArgs)) { handleAllErrors(std::move(E), [&](ErrorInfoBase &EIB) { ---------------- tejohnson wrote: > Document constant parameter Done. ================ Comment at: llvm/include/llvm/LTO/LTOBackend.h:48 /// Runs a ThinLTO backend. Error thinBackend(const Config &C, unsigned Task, AddStreamFn AddStream, ---------------- tejohnson wrote: > Can you add a note here about the behavior with regards to ModuleMap > depending on whether it is null or not? Add the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99554/new/ https://reviews.llvm.org/D99554 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits