serge-sans-paille added inline comments.
================ Comment at: clang/lib/Sema/SemaDecl.cpp:13640 + warnOnReservedIdentifier(New); + ---------------- aaron.ballman wrote: > rsmith wrote: > > serge-sans-paille wrote: > > > serge-sans-paille wrote: > > > > rsmith wrote: > > > > > Is there somewhere more central you can do this, rather than > > > > > repeating it once for each kind of declaration? (Eg, > > > > > `PushOnScopeChains`) > > > > That would be sane. I'll check that. > > > I tried PushOnScopeChains, and this does not capture all the required > > > declarations. I failed to find another place :-/ > > What cases is it missing? Can we add calls to `PushOnScopeChains` to those > > cases (perhaps with a new flag to say "don't actually push it into scope"?) > > I'm not super happy about adding a new thing that all places that create > > declarations and add them to scope need to remember to do, to drive this > > warning. Cases are going to get forgotten that way. > I'm still wondering about this as well. I'll investigate that one more deeply, I do share your concern. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
