kiranchandramohan accepted this revision.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: flang/include/flang/Frontend/CompilerInvocation.h:142
+ ///
+ /// \param [in] ppOpts The preprocessor options
+ void collectMacroDefinitions();
----------------
Nit: Misplaced? Don't see any params here.
================
Comment at: flang/include/flang/Frontend/CompilerInvocation.h:153
+ /// Updates this instance based on the extension of the input file (e.g. f90
+ /// s F90)
+ void updateBasedOnExtension(const FrontendInputFile &inputFile);
----------------
Nit: Should this have a param in?
================
Comment at: flang/include/flang/Frontend/FrontendOptions.h:147
+ /// predefinitions are added or not. In practice, this is sufficient to
+ /// implment gfortran`s logic controlled with `-cpp/-nocpp` flags.
+ unsigned mustBePreprocessed_ : 1;
----------------
Nit: implment -> implement
================
Comment at: flang/lib/Frontend/FrontendActions.cpp:68
bool PrescanAndSemaAction::BeginSourceFileAction(CompilerInstance &c1) {
CompilerInstance &ci = this->instance();
----------------
Nit: Looks similar to function above.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99292/new/
https://reviews.llvm.org/D99292
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
