aganea added a comment. >> In D99363#2653476 <https://reviews.llvm.org/D99363#2653476>, >> @abhina.sreeskantharajan wrote: >> >>> > > This was only other file from https://reviews.llvm.org/D96363 that was using > OF_TextWithCRLF instead of OF_Text. Please let me know if this latest patch > https://reviews.llvm.org/file/data/2jljo4tfl5aiisvwpzg2/PHID-FILE-egbpcbhz3t7b7a2tcjka/D99426.diff > fixes your issue.
There's no difference after applying the above change, I still see the issue. > I realized the change for DwarfLinkerForBinary.cpp was missing Sorry if I misunderstand, but I don't think DwarfLinkerForBinary.cpp is used when targeting Windows binaries. > If not, I will revert the remaining changes in my old commit to unblock you. I am not blocked. If the fix comes later on in the following days/weeks, I'm fine with that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99363/new/ https://reviews.llvm.org/D99363 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
