steakhal added a comment. In D83660#2661369 <https://reviews.llvm.org/D83660#2661369>, @martong wrote:
> I went through the change and it looks good, seems like this is indeed a copy > paste error from line 132. > I checked the related conversation, and thanks for all the effort spent with > the test. > >> BTW, I was obstructed by the z3 requirement in the regression test case when >> I tried to understand your test case. Even though I set the variables >> LLVM_Z3_INSTALL_DIR and LLVM_ENABLE_Z3_SOLVER during CMake, and the CSA can >> be correctly compiled with Z3, I still cannot make the test case run during >> make check-all. Therefore, this case was manually executed with llvm-lit >> -DUSE_Z3_SOLVER=1. Could you please tell me how to enable Z3 during llvm-lit. > > I am a bit unhappy that we cannot run the test automatically, but maybe in > the future. > @steakhal, https://reviews.llvm.org/D83677 seems to be related, should we > push that? I wouldn't mind fixing that yes, but right now I'm busy with other things. Let's come back to it later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83660/new/ https://reviews.llvm.org/D83660 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
