ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed.
I'm personally not so concerned with the Clang driver side of things, but primarily with adding more complexity to the libc++ build. Shouldn't we be driving things from the runtimes build and setting a different `CMAKE_INSTALL_PREFIX` to install stuff to the right location instead? Then you can run N builds of libc++ for N targets, each setting the appropriate install path. ================ Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:379 + + // Second add the generic one. + P.assign(Path); ---------------- Doesn't that break `#include_next` if both directories exist? Generally speaking, I think you only ever want to have a single directory containing the libc++ headers on your header search path. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D89013 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
