glaubitz added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2110
+ static const char *const X32Triples[] = {"x86_64-linux-gnux32",
+ "x86_64-unknown-linux-gnux32",
+ "x86_64-pc-linux-gnux32"};
----------------
hvdijk wrote:
> MaskRay wrote:
> > Personally I'd defer adding a triplet until it is proven to be used on a
> > system.
> >
> > This is not free, for every x86-64 user (even if they don't use multilib or
> > x32), their clang driver runs need to stat the directory under lib/gcc or
> > lib/gcc-cross.
> For the first and last I know for a fact they are used as the GCC triple;
> /usr/lib/gcc/x86_64-linux-gnux32 and /usr/lib/gcc/x86_64-pc-linux-gnux32
> definitely both exist in the wild. For the middle,
> x86_64-unknown-linux-gnux32, I do know for a fact this is used as a triple
> (it is the only valid x32 triple for Rust), but it is possible it is not used
> as the GCC triple anywhere, so unless someone speaks up that this is already
> in use somewhere, I will take that one out.
Isn't Rust going to use `x86_64-unknown-linux-gnux32` when invoking the C++
compiler itself? I would prefer keeping it for consistency with x86_64 and to
avoid issues with distributions that may use that triplet.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52050/new/
https://reviews.llvm.org/D52050
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
