rogfer01 added inline comments.
================ Comment at: clang/lib/AST/ASTContext.cpp:1486 + BuiltinType::Kind K, unsigned NF) { + auto TypeIter = llvm::find_if(Types, [&K](Type *Ty) { + if (Ty->isBuiltinType()) { ---------------- I'm confused by this lookup. If you add `RvvInt8mf8Ty` in the macros above will you be able to use it for types such as `RvvInt8mf8x2Ty`, `RvvInt8mf8x3Ty`, etc. without having to search it in all the types? AFAICT `ElemId` seems only used in this case so perhaps we can use the "name of the field of ASTContext" (a `CanQualType`) directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97264/new/ https://reviews.llvm.org/D97264 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits