probinson added a reviewer: dblaikie. probinson added inline comments.
================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1648 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) ---------------- I think we don't want this enabled by default at -O0. It doesn't run any optimizations that should eliminate parameters, so this is going to increase debug info size for no real benefit to the debugging experience. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99238/new/ https://reviews.llvm.org/D99238 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits