jrtc27 added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11190 +def err_riscv_builtin_requires_extension : Error< + "builtin requires %0 extension support to be enabled">; } // end of sema component. ---------------- This lost the quotes ================ Comment at: clang/lib/Sema/SemaChecking.cpp:3427 + continue; + // Make message like "experimental-zbr" to "Zbr" + I.consume_front("experimental-"); ---------------- both to improve the English and to be clear that this is for non-experimental feature strings too ================ Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:19 + + class BitMan_GPR_Intrinsics + : Intrinsic<[llvm_any_ty], ---------------- This file, like the rest of LLVM, uses a 2-space indent, not 4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99009/new/ https://reviews.llvm.org/D99009 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits