fhahn added reviewers: rsmith, erichkeane.
fhahn added inline comments.

================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1209
+    if (isa<llvm::IntegerType>(DstTy))
+      Res = Builder.CreateIntCast(Src, DstTy, InputSigned, "conv");
+    else if (InputSigned)
----------------
now that' this is a separate function, we should be able to just return the 
created value directly, right? There should be no need for `Res`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100051/new/

https://reviews.llvm.org/D100051

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to