jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:663
+ // Create our global prioritized cleanup function.
+ if (!PrioritizedCXXStermFinalizers.empty()) {
----------------
Just noting that this trunk of code have very similar logic counter part in
`EmitCXXGlobalInitFunc`. It seems there is no easy way to common them up given
the current way of implementing it. It may require a non-trivial amount of
refactoring for us to common up the similar logic between init and cleanup.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99291/new/
https://reviews.llvm.org/D99291
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
