bader marked an inline comment as done.
bader added inline comments.
================
Comment at: clang/include/clang/AST/Type.h:488
(A == LangAS::opencl_global && (B == LangAS::opencl_global_device ||
B == LangAS::opencl_global_host)) ||
// Consider pointer size address spaces to be equivalent to default.
----------------
BTW, we need enable `global_device` and `global_host` attributes from
https://reviews.llvm.org/D82174 for SYCL USM feature. I have following question
regarding this: should I create a follow-up patch or we can enable all
attributes for SYCL at once?
================
Comment at: clang/test/CodeGenSYCL/convergent.cpp:2
// RUN: %clang_cc1 -fsycl-is-device -emit-llvm -disable-llvm-passes \
-// RUN: -triple spir64-unknown-unknown-sycldevice -emit-llvm %s -o - | \
// RUN: FileCheck %s
----------------
Anastasia wrote:
> Is this change related? I thought we are not adding the environment component
> after all...
>
>
> Is this change related? I thought we are not adding the environment component
> after all...
While I was removing `-sycldevice` environment component from the patch, I
noticed that one of the committed tests already uses it.
https://github.com/llvm/llvm-project/blob/main/clang/test/CodeGenSYCL/convergent.cpp#L2
Do you want to me to create a separate review request for this change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89909/new/
https://reviews.llvm.org/D89909
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
