rsmith added inline comments.
================
Comment at: clang/include/clang/Basic/ABI.h:182
+ /// an ABI-specific comparator.
+ const CXXMethodDecl *BaseMethod;
+
----------------
Instead of the changes you made to `GlobalDecl`, I think this should be a
`GlobalDecl` itself. Different function variants could have different
signatures, so in principle at least, what we want to know is the function
variant not the function declaration.
================
Comment at: clang/lib/AST/VTableBuilder.cpp:1155-1157
+ // Override it. Note that there may or may not be a thunk already.
+ VTableThunks.erase(Idx);
+ VTableThunks.insert({Idx, *TI});
----------------
Can you modify the thunk info in-place, instead of this erase + insert dance?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100388/new/
https://reviews.llvm.org/D100388
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
