mibintc marked an inline comment as done. mibintc added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:299 + " with attribute 'no_caller_saved_registers'">, + InGroup<Extra>; def warn_arm_interrupt_calling_convention : Warning< ---------------- rsmith wrote: > Please don't add warnings directly to `-Wextra`; this should have its own > flag so that people who want to do this can turn the warning off without > turning off all of `-Wextra`. Thanks, I had thought about removing InGroup<Extra> before uploading to review but hurrying at the end of my work day and forgot. I was expecting the lit test to fail and I'd have to add Wextra onto the RUN line but I didn't need to do that, the diagnostic was produced without enabling. Anyway I got rid of it like you asked. BTW the only other diagnostic in this file marked Wextra is the arm diagnostic. That was added in https://reviews.llvm.org/D28820 "warn_arm_interrupt_calling_convention" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100511/new/ https://reviews.llvm.org/D100511 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
