rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, micro readability suggestion
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:5691
+ // no special handling of HFAs/HVAs.
+ if (isHomogeneousAggregate(Ty, Base, Members) && (!IsWin64 || !IsVariadic)) {
return ABIArgInfo::getDirect(
----------------
nit: I feel like this would be more readable and short-circuit better:
bool IsWinVariadic = IsWin64 && IsVariadic;
if (!IsWinVariadic && isHomogeneousAggregate(...)) {
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100467/new/
https://reviews.llvm.org/D100467
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
