rnk added a comment. In D100488#2689494 <https://reviews.llvm.org/D100488#2689494>, @amccarth wrote:
> Personally, I'm not a fan of boolean function parameters because of the > inline comments necessary to make the call site understandable. But it > appears to be consistent with LLVM Coding Standards and other APIs, so this > looks right to me. I think it would be a reasonable follow-up change to turn these optional boolean parameters into a flags enum. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100488/new/ https://reviews.llvm.org/D100488 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
