njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang/lib/Tooling/NodeIntrospection.cpp:33 } - result += (vec.back()->name() + "()").str(); + result += (vec.front()->name() + "()").str(); return result; ---------------- nit: rebase, this no longer exists. ================ Comment at: clang/lib/Tooling/NodeIntrospection.cpp:54-55 - return LHS.second->name() < RHS.second->name(); + return LocationCallFormatterCpp::format(LHS.second.get()) < + LocationCallFormatterCpp::format(RHS.second.get()); } ---------------- nit: This is quite an inefficient way to go about comparing these. Though it would require a bit of work to avoid creation of the temporary strings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100548/new/ https://reviews.llvm.org/D100548 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
