ggeorgakoudis marked 4 inline comments as done.
ggeorgakoudis added inline comments.
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:2192
RCG(CGF);
}
}
----------------
jdoerfert wrote:
> Can we remove SeqGen while we are here please. We need to check in the
> runtime anyway. That check is later folded, no need to make things more
> complicated here.
Done
================
Comment at: openmp/libomptarget/deviceRTLs/common/src/parallel.cu:294
+ // TODO: Add UNLIKELY to optimize?
+ if (!if_expr) {
+ __kmpc_serialized_parallel(ident, global_tid);
----------------
jdoerfert wrote:
> This should allow us to remove the `SeqGen` in the Clang CodeGen *and* fix
> PR49777 *and* fix PR49779, a win-win-win situation.
Please check
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95976/new/
https://reviews.llvm.org/D95976
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
