tra added a comment. > The planned new option for offloading will be a more generic solution, > however, I expect it will take time to develop and be adopted.
Agreed. OK, let's use a hidden option until we have a better way of dealing with this. ================ Comment at: clang/include/clang/Driver/Options.td:954 +def gpu_inline_threshold_EQ : Joined<["--"], "gpu-inline-threshold=">, + Flags<[CC1Option]>, + HelpText<"Inline threshold for device compilation for HIP">; ---------------- This option is only handled at the top level, it does not need `CC1Option`. It does need `HelpHidden`. Also, the option should probably be `-fgpu-inline-threshold=...` as it's a parameter tweak, and not something more serious, like `--offload-arch`. Naming is hard. :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99233/new/ https://reviews.llvm.org/D99233 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
