vsk added a subscriber: efriedma. vsk added a comment. Thanks for doing this!
+ Eli to comment on whether any workarounds documented in https://lists.llvm.org/pipermail/llvm-dev/2017-September/117156.html are still necessary. To my knowledge it's not currently necessary to explicitly pass -mllvm -enable-value-profiling=false (as value profiling should not be enabled under -fcoverage-mapping -fprofile-instr-generate). It should also not be necessary to shave .o's out of the runtime static archive; so long as the static initializer isn't linked, the linker shouldn't pull in any references to malloc, mmap, etc. ================ Comment at: clang/docs/SourceBasedCodeCoverage.rst:368 + +In C++ files, declare these as ``extern "C"``. + ---------------- I think we should leave a note about how to avoid pulling in unwanted symbol references, and perhaps reference the preceding section about using the runtime without its static initializer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101000/new/ https://reviews.llvm.org/D101000 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
