crr0004 added a comment.

One thing I noticed was that you need to be over the base class or overriding 
class identifier in order to get the code action.

For some editors like Visual Studio Code this is less noticeable but for others 
like VIM it is more noticeable as you need to know it's there.

Is there a way to trigger the tweak when it is anywhere in the class? I have 
been investigating how to do it but I am still learning a lot about the clang 
AST and the internals of clangd.

What do other people think?

Might not be worth adding to this patch as it would over-complicate an already 
complicated patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94942/new/

https://reviews.llvm.org/D94942

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to