sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:142
this->Opts.ShouldTraverseDecl = [this](const Decl *D) {
+ // Many operations performed during indexing is linear in terms of depth
+ // of the decl (USR generation, name lookups, figuring out role of a
----------------
I'd consider pulling the logic out into `isDeeplyNested(unsigned MaxDepth=10)`
in AST.h, to keep this readable & policy-oriented and as we may well want to
apply this in other places where we use SymbolCollector (or other traversals)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101066/new/
https://reviews.llvm.org/D101066
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
