jsji added inline comments.

================
Comment at: clang/lib/Headers/altivec.h:3065
+                                                   (__b)),                     
\
+             vector unsigned long long                                         
\
+           : (__builtin_vsx_xvcvuxdsp((vector unsigned long long)(__a)) *      
\
----------------
jsji wrote:
> Can we also add comments about what is the major difference with and without 
> `__XL_COMPAT_ALTIVEC__` , for long term maintenance?
> Can we also add comments about what is the major difference with and without 
> `__XL_COMPAT_ALTIVEC__` , for long term maintenance?

I know they are in commit message, but I think comments in source code would be 
more helpful than in commit message. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101130/new/

https://reviews.llvm.org/D101130

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to