njames93 added inline comments.
================ Comment at: clang/include/clang/Tooling/NodeIntrospection.h:29 class CXXBaseSpecifier; +class DeclarationNameInfo; ---------------- Please fix this lint warning. ================ Comment at: clang/lib/Tooling/DumpTool/generate_cxx_src_locs.py:394-398 cladeName not in [ 'NestedNameSpecifierLoc', + 'DeclarationNameInfo', 'TemplateArgumentLoc', 'TypeLoc']) ---------------- Kind of unrelated, but can these not be replaced with `cladeName not in RefClades`? ================ Comment at: clang/unittests/Introspection/IntrospectionTest.cpp:1431-1433 + if (Result.LocationAccessors.empty() && Result.RangeAccessors.empty()) { + return; + } ---------------- Can this be replace with a ```lang=c++ if (!NodeIntrospection::hasIntrospectionSupport()) return; ``` Check at the start of the test? Same goes for the rest of the tests added here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101049/new/ https://reviews.llvm.org/D101049 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits