kadircet added a comment. > Hit send too soon. But IIRC PP knows whether it's building a preamble.
That's a good point. But PP doesn't know if there's trailing content or not (in clangd's case). So we'll end up not showing the diag even when we should (i.e. whole file is preamble without a new line at eof). It doesn't sound too bad, but it'll effect all tools building preambles (including clang) and not just clangd so I am a little hesitant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100501/new/ https://reviews.llvm.org/D100501 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
