phosek added a comment.

I don't think this is sufficient. First, we want to be explicit and always list 
individual files to install, we don't use patterns. Second, since libscanbuild 
is a library, it shouldn't be installed inside the `bin` directory. I think 
those should go either into `lib` or `share`. `libscanbuild/resources` should 
definitely go into `share` as is already the case for `scan-build`. Third, 
`libear` is a native component so that one needs to be compiled first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101139/new/

https://reviews.llvm.org/D101139

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to