jansvoboda11 added inline comments.
================ Comment at: clang/lib/Serialization/ASTReader.cpp:5621 + // FIXME: NameAsWritten + ModMap.setUmbrellaHeader(CurrentModule, *Umbrella, Blob, ""); else if (CurrentModule->getUmbrellaHeader().Entry != *Umbrella) { ---------------- Not sure what's the best way to write/read the two strings (`NameAsWritten`, `PathRelativeToRootModuleDirectory`). Can we put them into a single blob and separate them with `\0`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100934/new/ https://reviews.llvm.org/D100934 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits