aaron.ballman accepted this revision. aaron.ballman added a comment. Just one drive-by nit from me.
================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4119-4123 + if (LangOpts.SYCLIsDevice) { + if (!D || D->getType().getAddressSpace() == LangAS::Default) { + return LangAS::sycl_global; + } + } ---------------- Just simplifying the logic a bit, likely needs to be reformatted though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits