leonardchan added a comment. > That's odd. Does your `CMakeCache.txt` file have > `CLANG_ROUND_TRIP_CC1_ARGS:BOOL=OFF` by any chance? It's possible it didn't > get switched to `ON` when D97462 <https://reviews.llvm.org/D97462> landed. > > With the way the tests are written now, I'd expect them to fail in assert > build without the code generating `-fcxx-abi=`.
Ah, I did not have that flag ON by default (incrementally working off an old invocation), and turning this on without the `GenerateArg` bit causes `cxx-abi-switch.cpp` to fail. Thanks for catching this! In D85802#2713395 <https://reviews.llvm.org/D85802#2713395>, @phosek wrote: > I don't see any checks to ensure that the selected ABI is compatible with the > specified target, is that something you plan on implementing in a follow up > change? Added a check for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85802/new/ https://reviews.llvm.org/D85802 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
