NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

This looks like the fix is in the right place and it looks more or less how I 
expected it to look. Our casting procedure hopefully became more correct and 
now we have more correct analysis everywhere. It's still hard to tell whether 
this `ElementRegion` should be there or not, given how nobody still knows why 
they're there and when exactly should they be there; the very representation of 
casted pointers still needs a major rework. But we get there when we get there. 
Thanks a lot for debugging and digging and refactoring along the way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89055/new/

https://reviews.llvm.org/D89055

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to