njames93 added inline comments.

================
Comment at: 
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-ignoreconversionfromtypes-option.cpp:12
+
+typedef long long size_t;
+
----------------
This is breaking tests on windows, It seems like its pre-defined to be 
`unsigned long long` on windows.
Simplest fix is to rename size_t to something else.
I guess changing the typedef to `unsigned long long` will change behaviour of 
tests.
Failing that an `// UNSUPPORTED: system-windows` directive at the top of the 
file would also work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99543/new/

https://reviews.llvm.org/D99543

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to