aeubanks added a comment.
As you said in the description, this overlaps a lot with -debug-pass-manager.
What exactly is too verbose with the existing debug logging? I'd strongly
prefer to have this consolidated into one pass instrumentation rather than two.
Having a new pipeline test is very tedious when changing the pipeline. We
already have a bunch.
================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:23
#include "llvm/IR/Function.h"
+#include "llvm/IR/LegacyPassManager.h"
#include "llvm/IR/Module.h"
----------------
is this needed?
================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:55
+static cl::opt<bool>
+ DebugPassStructure("debug-pass-structure", cl::Hidden, cl::init(false),
----------------
The new PM design tries to avoid global options. We should implement the above
FIXME and fold this into `PrintPassInstrumentation`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99599/new/
https://reviews.llvm.org/D99599
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
