Anastasia added inline comments.

================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10006
   "use of %select{type|declaration}0 %1 requires %2 support">;
+def ext_opencl_double_without_pragma : Extension<
+  "Clang permits use of type 'double' regardless pragma if 'cl_khr_fp64' is 
supported">;
----------------
azabaznov wrote:
> nit: this can be extended to use arbitrary type and extension for other 
> patches which will eliminate pragmas for types
Well, actually I am not sure we should use it elsewhere because I don't think 
it really applies universally.
The situation for `doubles` seems to be that the older specs were intructing to 
use the pragma explicitly.

For the future work we should just avoid adding or using pragma at all unless 
it brings beneficial functionality.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100980/new/

https://reviews.llvm.org/D100980

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to